From 9aeb937c019527b59af003c5b1cf74544aa4fe40 Mon Sep 17 00:00:00 2001 From: denz1994 Date: Fri, 18 Jan 2019 12:37:19 -0500 Subject: [PATCH] Addressed TODO: Phet-io tandems for Text https://github.com/phetsims/masses-and-springs-basics/issues/48 --- js/lab/view/GravityAccordionBox.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/lab/view/GravityAccordionBox.js b/js/lab/view/GravityAccordionBox.js index 093eea5..4f2c22c 100644 --- a/js/lab/view/GravityAccordionBox.js +++ b/js/lab/view/GravityAccordionBox.js @@ -62,12 +62,13 @@ define( require => { } ); gravitySlider.addMajorTick( MassesAndSpringsConstants.GRAVITY_RANGE.min, new Text( noneString, { font: MassesAndSpringsConstants.LABEL_FONT, - tandem: tandem.createTandem( 'gravityNoneString' ), // REVIEW: Tandem should be for the 'Text', not a 'String'? + tandem: tandem.createTandem( 'gravityNoneText' ), // REVIEW: Tandem should be for the 'Text', not a 'String'? + // *REVIEW: review with JO and update updat maxWidth: MAX_WIDTH * 0.5 } ) ); gravitySlider.addMajorTick( MassesAndSpringsConstants.GRAVITY_RANGE.max, new Text( lotsString, { font: MassesAndSpringsConstants.LABEL_FONT, - tandem: tandem.createTandem( 'gravityLotsString' ), + tandem: tandem.createTandem( 'gravityLotsText' ), maxWidth: MAX_WIDTH * 0.5 } ) );