Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the position of the area labels on the second screen #37

Closed
2 tasks
DianaTavares opened this issue May 11, 2023 · 4 comments
Closed
2 tasks

Improve the position of the area labels on the second screen #37

DianaTavares opened this issue May 11, 2023 · 4 comments

Comments

@DianaTavares
Copy link

  • the suggestion was that for big areas the label could be placed inside the orbit, to allow to see the numbers in big orbits:

image

For medium and small orbits, are ok to have the labels outside the orbit:
image

  • but in some small orbits, the labels overlap with the orbit. This need to be solved.

image

@AgustinVallejo
Copy link
Contributor

Pushed a commit that handles as you asked, please review and let me know what you think!

@DianaTavares
Copy link
Author

When the orbit is small, the labels still going inside the orbit:
image

and when it is big, still the labels being out:
image

@DianaTavares
Copy link
Author

Better!!
but now the labels overlap sometime when they are inside the orbit:
image

and sometimes we have something like this:
image

Also, can be problematic if some labels overlap with more of one area. For example, the labels close to the sun are half in one area and half in the other area:

image

I suggest making the change of the labels between inside to outside in bigger orbits. Something like this can be the smaller orbit with the labels inside:
image

Is there a way to place better the labels when they are inside? There is space for having each label just in its area with an adjustment a little more up for some labels, and to the right for other labels. It is possible to do this dynamically and improve it?

image

@DianaTavares
Copy link
Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants