Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused translations of region and culture strings #975

Open
jbphet opened this issue Jul 2, 2024 · 1 comment
Open

Delete unused translations of region and culture strings #975

jbphet opened this issue Jul 2, 2024 · 1 comment
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 2, 2024

Issue #958 contains a list of steps that was needed to migrate from one approach for handling region and culture selections to a new one that was in common code. It looks like one step was missed - removing the strings that were translated while the older approach was in place. I've looked through the translations, and it looks like only energy-skate-park and soccer-common have these strings. They should be removed so that they don't cause confusion in the future.

@jbphet jbphet self-assigned this Jul 2, 2024
@jbphet
Copy link
Contributor Author

jbphet commented Jul 2, 2024

Before doing this, we would need to make sure that the affected sims have been re-published with the updated code and are no longer referencing their own sim-specific versions of these strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant