Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long strings cause screen buttons to overlap #718

Closed
liammulh opened this issue May 21, 2021 · 4 comments
Closed

Long strings cause screen buttons to overlap #718

liammulh opened this issue May 21, 2021 · 4 comments

Comments

@liammulh
Copy link
Member

Test Device

MacBook Air

Operating System

macOS 11.2.3

Browser

Safari 14.0.3

Problem Description

For phetsims/qa#650. Perhaps related to #645.

If you put in the standard ?stringTest=long string (or one with a similar number of characters), the screen buttons get shifted over and can overlap. See the screenshot below. With ridiculously long strings, the screen buttons will disappear entirely.

Assigning @jonathanolson because he's working on #645 and these issues seem related.

Visuals

buttons

@KatieWoe
Copy link

I saw a similar shift of the icon when the label text disappears as well.
shiftingicon

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 1, 2021

Is this the same as #725?

This issue should definitely be blocking, because it affects usability of the navigation bar.

@pixelzoom
Copy link
Contributor

This is blocking phetsims/qa#657 and phetsims/qa#662. Since the latter has top priority, this issue is elevated to top priority.

@samreid
Copy link
Member

samreid commented Jul 8, 2021

This seems like a duplicate of #725, closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants