Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-modal dialog must have close button #292

Closed
pixelzoom opened this issue Aug 19, 2015 · 4 comments
Closed

non-modal dialog must have close button #292

pixelzoom opened this issue Aug 19, 2015 · 4 comments
Assignees
@andrealin

Comments

@pixelzoom
Copy link
Contributor

Related to #166.

If a Dialog has modal: false, then it had better have hasCloseButton:true. If not, there's no way to close the dialog. Add an assertion to verify this.
@pixelzoom pixelzoom mentioned this issue Dec 28, 2015
Closed
@pixelzoom
Copy link
Contributor Author

Moved this issue to a requirement in #359. Closing.

@pixelzoom
Copy link
Contributor Author

This got moved to #359, but has not been addressed. Reopening because the "closed" state gives the illusion that this was fixed, and it is not.

@pixelzoom pixelzoom reopened this Apr 25, 2017
@pixelzoom
Copy link
Contributor Author

3/29/18 dev meeting: @andrea-phet and I will triage this issue.

@pixelzoom
Copy link
Contributor Author

According to #413, all dialogs (modal and non-modal) must have a close button for a11y. That issue supersedes this one, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrealin andrealin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @andrealin