Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-modal option of Dialog doesn't work #290

Closed
pixelzoom opened this issue Aug 19, 2015 · 1 comment
Closed

non-modal option of Dialog doesn't work #290

pixelzoom opened this issue Aug 19, 2015 · 1 comment
Labels

Comments

@pixelzoom
Copy link
Contributor

Factored out of #166 (create a Dialog base type). I tested the modal option of joist.Dialog, and it doesn't work as expected.

I set modal: true on line 108 of AboutDialog.js, ran a sim in requirejs mode, and opened the AboutDialog. It behaved exactly like a modal dialog.

As described in the requirements for #166, a non-modal dialog allows you to interact with the sim while the dialog is open. And the dialog must be closed via close button or some interaction with dialog’s component.

@pixelzoom pixelzoom changed the title modal option of Dialog doesn't seem to work modal option of Dialog doesn't work Aug 19, 2015
@pixelzoom pixelzoom changed the title modal option of Dialog doesn't work non-modal option of Dialog doesn't work Aug 19, 2015
@pixelzoom
Copy link
Contributor Author

My bad on this one. I was actually testing modal. Retested with non-modal and it seems to work OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant