Avoid using ToggleNode in the NavigationBarScreenButton

[samreid]

In phetsims/energy-skate-park-basics#208, I said:

I tried getting @jonathanolson's changes to NavigationBarScreenButton from joist/ohtwo and this reduced the number of nodes from 509 to 344. In my opinion, that is very significant. I'll look into merging that commit into master.

[samreid]

Note, the work was done by @jonathanolson in f31cde3, and just needs to be merged in from ohtwo to master. I'll try git cherry-pick, but I haven't used cherry-pick before and not sure if it is the perfect thing.

git cherry-pick f31cde3

[samreid]

After running the command above, the system reported:

[master e09cf43] NavigationBarScreenButton rewrite so we don't have 8 copies of our icon per screen.  Significantly smaller scene graph for some sims. Possibly
relates to #137, #108, #94, #80.
 Author: Jonathan Olson <[email protected]>
 1 file changed, 80 insertions(+), 64 deletions(-)
 rewrite js/NavigationBarScreenButton.js (62%)

Tests seemed good, so I'll push shortly.

[samreid]

I pushed the cherry-pick to master above, which was committed as e09cf43

[samreid]

Everything above seems promising, though there is the possibility we could run into issues when running a more full merge to ohtwo in the future.

[samreid]

I'll close this issue now since the rewritten buttons are in master.