Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDOM) Orientation vertical for Arm Swing slider #454

Open
terracoda opened this issue Nov 30, 2021 · 0 comments
Open

(PDOM) Orientation vertical for Arm Swing slider #454

terracoda opened this issue Nov 30, 2021 · 0 comments

Comments

@terracoda
Copy link
Contributor

In the initial release of John Travoltage we kept the sliders with the same orientation (horizontal). This meant the default go to keys to use were the Left and Right Arrow keys. The Keyboard Shortcuts dialog look like this:
image

With the release of the sim with Voicing we changed the default keys in the Keyboard Shortcuts dialog to prefer the Up and Down Arrow keys. This better matches the visual experience when a learner is using the keyboard. The Keyboard Dialog now looks like this:
image

We have not yet explicitly changed the aria-orientation of the Arm Swing in the HTML to be aria-orientation="vertical". Since the "horizontal" orientation is the default, is not explicitly read out when using screen reader software. However, an orientation of "vertical" is read out (at least with VoiceOver, it is read out). The vertical orientation cues blind learners to use the Up and Down arrow keys. I have heard this in interviews.

Since we changed the preferred keys to be Up and Down, and updated the Keyboard Shortcuts dialog, I think we should take the next step and actually change the orientation of the Arm Swing slider so that it presents itself as a vertical slider. This would alert screen reader users to start their exploration with the Arm Swing by using the Up and Down arrows. Of course, all arrow keys will work, but because of the circular motion of the Arm Swing, one set of Arrow keys (the Up and Down keys) seem to feel visually more correct when starting the exploration with the Hand pointing at upper door.

@terracoda terracoda self-assigned this Nov 30, 2021
@terracoda terracoda removed their assignment Jun 10, 2022
@terracoda terracoda changed the title (PDOM) Consider orientation vertical for Arm Swing slider (PDOM) Orientation vertical for Arm Swing slider Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants