Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrons not being announced by VoiceOver #210

Closed
jobara opened this issue Apr 5, 2017 · 13 comments
Closed

Electrons not being announced by VoiceOver #210

jobara opened this issue Apr 5, 2017 · 13 comments
Assignees

Comments

@jobara
Copy link
Contributor

jobara commented Apr 5, 2017

I'm able to navigate to the leg and rub the foot across the carpet using VoiceOver. Visually I can see that electrons are accumulating, but there is not announcement of this by VoiceOver.

Using Safari 10.0.3 on macOS 10.12.3 with VoiceOver

@terracoda
Copy link
Contributor

@jobara, I tested on the same platforms, I hear the electron count sometimes, but not all the time. It seems to go back and forth sometime lots of leg position descriptions then lots of electron counts.

@jobara
Copy link
Contributor Author

jobara commented Apr 5, 2017

@terracoda for the most part i was moving the leg slowly. 1 key press, wait for the announcement, then press again. I did hear the position announced twice. Were you interacting the same way? I wonder if it maybe related to how quickly the leg is moved, interruptions with announcements, or something else? @jessegreenberg could it be related to the event emitter for the electrons?

@jessegreenberg
Copy link
Contributor

I wonder if it maybe related to how quickly the leg is moved, interruptions with announcements,

That seems likely, but I haven't been able to reproduce this myself. I am using Safari 9.0.1 with OSX 10.9.5.

@jessegreenberg
Copy link
Contributor

could it be related to the event emitter for the electrons?

Possibly, though I thought we only added emitters for when charges exit the body. Ill see if I can grab a newer version of Safari and macOS

@jessegreenberg
Copy link
Contributor

@phet-steele has latest macOS and was able to reproduce this bug.

@jessegreenberg
Copy link
Contributor

Since it isn't happening on older VoiceOver/Safari, this seems more like a VoiceOver issue with interrupting announcements.

@terracoda
Copy link
Contributor

@jobara, @jessegreenberg I was going fast then slow. The experience is so much slower when using VoiceOver than when using the keyboard alone. With keyboard alone, the slider works perfectly.

I thought I would try using the mouse while also using VoiceOver. At first I had a long run where I only got foot position. When I clicked away from the foot, I got the electron count. After a discharge and a reset, I only got electron information. ....Oh, I see, I have to tab to the sliders and put keyboard focus on the leg or the hand to hear position information when using the mouse. At first, I always heard discharges, but after using the arm I am no longer hearing discharge information. Hmm, seems that descriptions are dropped from the VO cue when using the mouse rather erratically.

I'm actually now having trouble operating the sliders at all when using VoiceOver. Maybe I have a weird keyboard setting turned on.

@jobara
Copy link
Contributor Author

jobara commented Apr 6, 2017

@terracoda I find at times that things just stop working the way I expect in VoiceOver and I just reset all of it's settings, and things start to work again. I'm not sure why this is. If it's something I'm doing that's causing it, or some bug in VoiceOver.

@terracoda
Copy link
Contributor

@jobara, I find the same thing. BTW, are you using VO keys and Arrow keys to operate the sliders or just the Arrow keys alone? My keyboard focus switches when I use the Arrow keys, though in my previous test I was able to operate the slider.

@jessegreenberg
Copy link
Contributor

@mbarlow12 and I found that the alerts can be heard on VoiceOver with macOS when the aria-atomic attribute is removed. I don't actually remember why that attribute is there, @jobara can it be removed?

@jobara
Copy link
Contributor Author

jobara commented Apr 10, 2017

@jessegreenberg here's the write up on aria-atomic ( https://www.w3.org/TR/wai-aria/states_and_properties#aria-atomic ). I'm guessing it's for cases where only a single value in a structure is changed, example if the alert is "electrons: 5" and only the 5 is changing. You'd want it to read "electrons: 6" and not just "6". In our case if we're changing the entire node anyways, it shouldn't make a difference and removing "aria-atomic" should be fine.

@jessegreenberg
Copy link
Contributor

Excellent, thanks @jobara.

@jessegreenberg
Copy link
Contributor

Updates are coming through again consistently, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants