Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing incorrect atoms into the play area via element selection buttons #46

Closed
phet-steele opened this issue Jan 27, 2016 · 3 comments
Closed
Assignees

Comments

@phet-steele
Copy link

Another way to cause an incorrect element to be placed in the play area:

Turns out the smaller periodic table buttons have a consequence of firing on a mouse up event (in other words, the element selected doesn't change until the mouse button is released as opposed to when the mouse button is pressed).

  1. Go to the Mix Isotopes screen, and choose an element.
  2. Place at least one atom into the play area.
  3. Switch to a different element, then switch back to your original element.
  4. Using the atom that was placed in the play area, drag it towards the small periodic table. Release your mouse and the atom once you cursor is over one of the small element buttons.

isoatma3

Tested in 1.0.0-dev.5 with Win 8.1 Chrome and OSX 10.11.2 (dirac). For phetsims/tasks/issues/488.

Troubleshooting information:
Name: ‪Isotopes And Atomic Mass‬
URL: http://www.colorado.edu/physics/phet/dev/html/isotopes-and-atomic-mass/1.0.0-dev.5/isotopes-and-atomic-mass_en.html
Version: 1.0.0-dev.5 2016-01-26 23:09:01 UTC
Features missing: touch
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36
Language: en-US
Window: 1366x643
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {"assert":{"sha":"d4909677","branch":"master"},"axon":{"sha":"5a39ec57","branch":"master"},"babel":{"sha":"db982666","branch":"master"},"brand":{"sha":"8c6f9c04","branch":"master"},"chipper":{"sha":"57c99807","branch":"master"},"dot":{"sha":"ddf82014","branch":"master"},"isotopes-and-atomic-mass":{"sha":"3d0c3bb9","branch":"master"},"joist":{"sha":"4c228a32","branch":"master"},"kite":{"sha":"4a947119","branch":"master"},"phet-core":{"sha":"874a703d","branch":"master"},"phetcommon":{"sha":"3db92af3","branch":"master"},"scenery":{"sha":"953fe860","branch":"master"},"scenery-phet":{"sha":"e903fad2","branch":"master"},"sherpa":{"sha":"bf82eb95","branch":"master"},"shred":{"sha":"c1d4863f","branch":"master"},"sun":{"sha":"45c7d334","branch":"master"},"tandem":{"sha":"5388a9e4","branch":"master"}}

@aadish
Copy link
Contributor

aadish commented Feb 8, 2016

@samreid Fixing this issue required adding the button listener for periodic table cell. This involved some change in tandem emitters.
The code change piece of code is here phetsims/shred@a1fe879

Can you review it to see if it doesn't break tandem

@aadish aadish assigned samreid and unassigned aadish Feb 8, 2016
@samreid
Copy link
Member

samreid commented Feb 19, 2016

I reviewed the change set and looked at the output from the periodic table cells, all seems good. Anything else to do here @aadish?

@samreid samreid assigned aadish and unassigned samreid Feb 19, 2016
@aadish
Copy link
Contributor

aadish commented Feb 19, 2016

thanks @samreid for reviewing nothing else has to be done. Closing this as the behavior is working fine.

@aadish aadish closed this as completed Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants