Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change string keys #43

Closed
jessegreenberg opened this issue Mar 2, 2018 · 2 comments
Closed

Change string keys #43

jessegreenberg opened this issue Mar 2, 2018 · 2 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

For #30 and dependent on #26. I would recommend making these keys a little more friendly for translators.

  "force-description-pattern-target_source": {
    "value": "Force on {0} by {1}"
  },
  "force-description-pattern-target_source_value": {
    "value": "Force on {0} by {1} = {2} N"
  },

source and source-value don't really signify the purpose to me. @mbarlow12 what do you think about
forceOnObjectByObjectPatternString and
forceOnObjectByObjectWithUnitsPatternString

Do you know if these keys were copied from gravity-force-lab strings or did we come up with them as we made ISLC?

@mbarlow12
Copy link
Contributor

mbarlow12 commented Mar 2, 2018

Works for me. Would forceOnObjectByOtherObject be too verbose/redundant?

@mbarlow12
Copy link
Contributor

mbarlow12 commented Mar 2, 2018

Completed in 303b54c, but I suppose we can wait to tackle #26 until we're closer to releasing the sim. I'll keep my assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants