New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape key does not exit dialogs #88

Closed

stemilymill opened this issue Sep 17, 2021 · 1 comment

Assignees

Labels

type:bug

stemilymill commented Sep 17, 2021

for phetsims/qa#707
Noticed on multiple platforms

Hitting the escape key does not exit dialogs and menus.

Keystrokes are shown at the bottom of the video:

esc.does.not.exit.dialogs.mp4

stemilymill added the type:bug label

stemilymill assigned jbphet

Contributor

jessegreenberg commented Sep 17, 2021

Thanks @stemilymill - This one is happening because https://phet-dev.colorado.edu/html/greenhouse-effect/1.0.0-rc.1/phet/greenhouse-effect_all_phet.html is going out with Interactive Description disabled. This means that no keyboard input will be working yet. I just tested that using ?supportsInteractiveDescription=true query param has the escape key closing dialogs.

jessegreenberg closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment