Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick label max widths don't match #253

Closed
marlitas opened this issue Jan 6, 2023 · 1 comment
Closed

Tick label max widths don't match #253

marlitas opened this issue Jan 6, 2023 · 1 comment
Assignees
Labels
type:suggestion type:wontfix This will not be worked on

Comments

@marlitas
Copy link
Contributor

marlitas commented Jan 6, 2023

Test device
Mac

Operating System
OS 13.01

Browser
Chrome

Problem description
phetsims/qa#871
The maxWidth for tick labels for the Solar Intensity, Surface Albedo, and Infrared Absorbance sliders do not seem to match, and it looks a bit odd. Would recommend matching those if possible.

Steps to reproduce

  1. Open Layer Model screen with query parameter stringTest=double

Visuals
Screenshot 2023-01-06 at 10 45 31 AM

Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: ‪Greenhouse Effect‬:‪Greenhouse Effect‬
URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.1.0-rc.1/phet/greenhouse-effect_all_phet.html?stringTest=double
Version: 1.1.0-rc.1 2022-12-23 00:15:29 UTC
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36
Language: en-US
Window: 1920x944
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 31 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@jbphet jbphet added the type:wontfix This will not be worked on label Jan 6, 2023
@jbphet
Copy link
Contributor

jbphet commented Jan 6, 2023

@arouinfar and I discussed this, and we feel that the behavior is okay as is. Perhaps this looks a bit odd due to the scaling down of the third slider that is caused be it being in a node with a long title, but since translations are unlikely to have the same length strings, and since many of the labels are using patterns that are unlikely to be lengthened significantly be translators, this doesn't seem worth the time.

@jbphet jbphet closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:suggestion type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants