Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus highlight outside dev bounds #247

Closed
Tracked by #885
amanda-phet opened this issue Jan 6, 2023 · 3 comments
Closed
Tracked by #885

Focus highlight outside dev bounds #247

amanda-phet opened this issue Jan 6, 2023 · 3 comments

Comments

@amanda-phet
Copy link

Test Device

iPad

Operating System

iOS16

Browser

Safari

Problem Description

For phetsims/qa#871. This probably doesn't need to change, but I noticed this when using the iPad with focus highlights turned on and confirmed here using dev. The focus highlight extends beyond the width of the iPad.

Steps to Reproduce

Turn on focus highlights
Go to Layer Model screen
Touch the temperature units

Visuals

image

Troubleshooting Information

blah

Steps to reproduce:

@jbphet
Copy link
Contributor

jbphet commented Jan 6, 2023

Good eye. I reviewed this with @samreid and @arouinfar and we decided to simply move the collection of controls a bit to the right, so I'll do that.

@jbphet
Copy link
Contributor

jbphet commented Jan 13, 2023

I just tested this and it is no longer a problem. I believe it was fixed by some work that was done to make the spacing between screen elements and the dev bounds more consistent, see 4874259.

@Nancy-Salpepi
Copy link

Looks good in rc.2
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants