Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight string overlap with mass labels #237

Closed
KatieWoe opened this issue Jan 29, 2020 · 2 comments
Closed

Slight string overlap with mass labels #237

KatieWoe opened this issue Jan 29, 2020 · 2 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 10
Browser
Edge
Problem description
For phetsims/qa#471
When strings are long or double, the m1 and m2 labels beneath the masses can overlap if they get too close to each other.

Visuals
stringoverlap

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Gravity Force Lab‬:‪Gravity Force Lab‬
URL: https://phet-dev.colorado.edu/html/gravity-force-lab/2.2.0-rc.1/phet/gravity-force-lab_all_phet.html?stringTest=double
Version: 2.2.0-rc.1 2020-01-28 03:08:20 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 Edg/79.0.309.71
Language: en-US
Window: 1536x718
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@zepumph
Copy link
Member

zepumph commented Jan 30, 2020

We went over this at one point (can't remember the issue), but it turns out that it is very hard to detect this because the two masses are separate objects that don't know about each other's text positioning. I believe that we decided that this was acceptable. @arouinfar do you remember this at all?

@zepumph zepumph assigned arouinfar and unassigned zepumph Jan 30, 2020
@arouinfar
Copy link

@zepumph we discussed the label overlap to some extent in phetsims/inverse-square-law-common#79. For phet-brand, the string is never expected to exceed 2 characters (see phetsims/coulombs-law#78).

For PhET-iO the label overlap could be a real issue, as a client may want to change "m" to "mass" or "q" to "charge". In that case, the strings will inevitably overlap. In phetsims/inverse-square-law-common#79 there was mention of shifting the labels away from each other to avoid overlap. I think this could be more trouble than it'd be worth, given that there are very few cases where the strings would overlap.

I'm inclined to do nothing here, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants