Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should MassPDOMNode be disposable? #157

Closed
jessegreenberg opened this issue Jun 28, 2019 · 1 comment
Closed

Should MassPDOMNode be disposable? #157

jessegreenberg opened this issue Jun 28, 2019 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

It is likely not necessary, but since gravity-force-lab is a dependency for gravity-force-lab-basics, I am wondering if disposal should be supported.

My instinct is that it isn't necessary and we can assume that masses are persistent for the life of the sim. @zepumph what do you think?

For phetsims/gravity-force-lab-basics#156

@zepumph
Copy link
Member

zepumph commented Jun 28, 2019

Good question. I do not think that anything in ISL suite needs disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants