-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The times sign (HTML entity) is not correctly read by Voice Over #131
Comments
By literally, I meant VoiceOver says, "and times". |
In our alert implementation, we're setting @jessegreenberg I'll make an issue to discuss if we want to go this route or whether for cases such as this, we should simply spell out "times" (which is quite simple). |
I like the idea of using innerHTML for this, would there be any consequences in using AccessibilityUtil.setTextContent in AriaHerald? |
After @jessegreenberg's commit for phetsims/scenery-phet#441, VO renders the entity as the correct symbol; however, it's read as "multiplication" instead of "times". What's really odd is that the exact same text is in the lists describing each mass (first heading under the Play Area). In that case, VO properly reads "times". The only major difference here is that the For now, in the ISLC sims, I'll create a function for alerts that will write the word 'times' into the alert instead of the entity. |
@mbarlow12, great for trying to resolve this. I agree, it is more likely that the difference is caused by the aria-live region, rather than whether the content is in a I think it is best to use the word, "times", at least in the alert until we have time to investigate this further. It would just be too strange for users to hear, "multiplication", instead of "times" in any interviews that will happen early in the new year. It seems safe to leave the HTML entity in the PDOM page content if that's easy to do. However, if it is easier to swap them both out, please do so. |
@mbarlow12, just adding some references, in case we need them to investigate further:
More resources:
|
@mbarlow12, we are using a It likely won't matter since the entity is correctly rendered in the PDOM, just not in the alert. |
@mbarlow12, I also sent a question to the W3C WAI Interest Group list ([email protected]) |
@mbarlow12, I think we decided at our design meeting on Dec 17, 2018 that we will use words for scientific notation, at least for sure for the alerts, and I'll move this issue to the a11y-research repo. |
@mbarlow12, I assume the text-based strings for scientific notation in the design document are sufficient to implement this change. Let me know if you need anything else. Once implemented, we can close this issue. |
I just verified with VoiceOver that the multiplication sign has not been changed to the word, "times". I'll mark this issue on hold until we resume work on this sim. There is no scientific notation in GFL:BASICS and that sim is our priority at the moment. |
@zepumph, just removing onhold. |
@mbarlow12 in the scientific notation,
×
is read out literally by VoiceOver.Is it being read out correctly as "times" in NVDA?
Edited: That was supposed to be a question.
The text was updated successfully, but these errors were encountered: