-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass slider information ready for implementation #126
Comments
Referencing our main issue #109 in case that makes sense. |
@mbarlow12, nice job implementing the Mass slider values and alerts. Now it is time to iterate! Here's three things I think will improve the described interaction.
|
@mbarlow12, I have created issues for the iterations, so I am closing the issue. I think I forgot to assign this issue to you, apologies for that. |
@mbarlow12, I've reviewed the section on the Mass slider alerts in the design document. I added a little bit of clarifying text and crossed out some things that I think we should drop from our first iteration. I have marked the columns above the strings to show which ones I think should be
aria-valuetext
and which ones should be alerts with andaria live
region.I think you are in the middle of converting the Mass slider focus alerts to use aria-valuetext. Here is the link to focus examples in the design document and here is a link to examples of changing mass
The edge cases we can deal with after initial implementation.
Please note that I removed the described size of the mass on focus, so only the actual size and the comparative size should be in the
aria-valuetext
on focus.Please let me know if anything is not clear.
The text was updated successfully, but these errors were encountered: