Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass slider information ready for implementation #126

Closed
terracoda opened this issue Dec 12, 2018 · 3 comments
Closed

Mass slider information ready for implementation #126

terracoda opened this issue Dec 12, 2018 · 3 comments

Comments

@terracoda
Copy link
Contributor

@mbarlow12, I've reviewed the section on the Mass slider alerts in the design document. I added a little bit of clarifying text and crossed out some things that I think we should drop from our first iteration. I have marked the columns above the strings to show which ones I think should be aria-valuetext and which ones should be alerts with and aria live region.

I think you are in the middle of converting the Mass slider focus alerts to use aria-valuetext. Here is the link to focus examples in the design document and here is a link to examples of changing mass

The edge cases we can deal with after initial implementation.

Please note that I removed the described size of the mass on focus, so only the actual size and the comparative size should be in the aria-valuetext on focus.

Please let me know if anything is not clear.

@terracoda
Copy link
Contributor Author

Referencing our main issue #109 in case that makes sense.

@terracoda
Copy link
Contributor Author

terracoda commented Dec 14, 2018

@mbarlow12, nice job implementing the Mass slider values and alerts.

Now it is time to iterate! Here's three things I think will improve the described interaction.
I will make issues for the following items:

  1. The actual size in kilograms repeats in the alert. Please remove it from the alert. It should only be provided by the slider (i.e., in the aria-valuetext).

  2. Based on feedback from screen reader consultants, I've decided the described size of the spheres (e.g., tiny, very small, small, etc) provided in the focus alert, is not that useful, and really not useful in GFL:B. Please remove the described size information (i.e., {{mass-size-qualitative}}) from the focus alert. I've crossed this column out in the design and will remove it soon.

  3. More complicated is where to provide the comparable size information, in an alert or aria-valuetext. Is it possible to move the described comparable size, i.e., {{comparative-mass-size-qualitative}} to aria-valuetext?If this is easy, great. If not, we can discuss pros and cons. I was thinking it might be better to provide the describe "Force vector" size as a focus alert, and the state of the value and state of the masses in aria-valuetext.

@terracoda
Copy link
Contributor Author

@mbarlow12, I have created issues for the iterations, so I am closing the issue. I think I forgot to assign this issue to you, apologies for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant