From e80f6a13a20dd02e2025ac8dad56a097b17f7af7 Mon Sep 17 00:00:00 2001 From: Michael Barlow Date: Fri, 26 Oct 2018 00:03:45 -0600 Subject: [PATCH] a11y names for checkbox items, see #109 --- js/gravity-force-lab/view/GravityForceLabScreenView.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/gravity-force-lab/view/GravityForceLabScreenView.js b/js/gravity-force-lab/view/GravityForceLabScreenView.js index 5baac055..ce2a7993 100644 --- a/js/gravity-force-lab/view/GravityForceLabScreenView.js +++ b/js/gravity-force-lab/view/GravityForceLabScreenView.js @@ -177,16 +177,21 @@ define( function( require ) { massControlsNode.addChild( massControl2 ); var TEXT_SIZE = 15; + // TODO: implement correct string usage and review a11 best practices + // - double check enabling/disabling checkboxes var checkboxItems = [ new ISLCCheckboxItem( constantSizeString, model.constantRadiusProperty, { + accessibleName: 'Constant Radius', textSize: TEXT_SIZE, tandem: tandem.createTandem( 'constantRadiusCheckbox' ) } ), new ISLCCheckboxItem( forceValuesString, model.forceValuesProperty, { + accessibleName: 'Force Values', textSize: TEXT_SIZE, tandem: tandem.createTandem( 'forceValuesCheckbox' ) } ), new ISLCCheckboxItem( scientificNotationString, model.scientificNotationProperty, { + accessibleName: 'Scientific Notation', textSize: TEXT_SIZE, tandem: tandem.createTandem( 'scientificNotationCheckbox' ) } )