Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove described qualitative size of sphere in mass spheres' dynamic descriptions #87

Closed
terracoda opened this issue Jan 21, 2019 · 3 comments
Assignees

Comments

@terracoda
Copy link

@zepumph, in issue phetsims/gravity-force-lab#128 qualitative size was correctly removed from the aria-valuetext, however, I would also like it removed from dynamic descriptions in the PDOM for both simulations, BASICS and REGULAR.

I am adding screen shots for both sims, red lines strike out the size information that I would like removed.

GFL BASICS
remove-sise-mass-spheres

GFL REGULAR
gfl-regular-remove-size-from-dynamic-description

Note to self (@terracoda) this change has already been noted in design document.

@terracoda
Copy link
Author

@zepumph, because this change is the same for both sims, I think it might be an easy one to implement.

@zepumph
Copy link
Member

zepumph commented Feb 20, 2019

Assigning to @terracoda to work on further. At our meeting we were not totally sure if we want to remove them in both, or just BASICS.

@terracoda
Copy link
Author

@zepumph, yes, the actual described size of the spheres is not needed, and it has already been removed.

Only the comparative size is needed and that will be looked after in issue #96.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants