Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Main - Voicing and Interactive Description Context Responses are being spoken by VoiceOver #329

Open
terracoda opened this issue Apr 22, 2024 · 2 comments

Comments

@terracoda
Copy link

The double firing of context responses is visible in the A11y View Tool.

This is not happening in Production, and we don't want it to.

We have 5 sims with the Voicing feature, I have only checked GFLB's checkboxes. Need further investigation to see if the issue is wider spread.

Screenshot 2024-04-22 at 11 44 39

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 7, 2024

Reviewing the history for this - This started happening when Voicing was added generally to Checkbox in phetsims/sun#742.

The Voicing response is set through the Checkbox options - which announces to both Voicing and Interactive Description.

  // Utterances to be spoken with a screen reader after the checkbox is pressed. Also used for the voicingContextResponse.
  checkedContextResponse?: TAlertable;
  uncheckedContextResponse?: TAlertable;

In addition, this link announces the Interactive Description context response:
https://github.com/phetsims/gravity-force-lab/blob/a9442b3421b2f8aeff8610ccd7096b385c2f037a/js/view/GravityForceLabAlertManager.js#L81-L89

So I think the Voicing response needs to be done like the Interactive Description response, so that Voicing and Interactive Description can be unique.

However, https://github.com/phetsims/gravity-force-lab/blob/a9442b3421b2f8aeff8610ccd7096b385c2f037a/js/view/GravityForceLabAlertManager.js#L81-L89 is only done in GFL and not GFL:B?

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 7, 2024

There are a couple of options for this.

  1. Add an option to Checkbox to have a custom context response for voicing that is not the same as the interactive descriptoin context response.
  2. While helpful, that may not be best for this issue. It seems like there is custom timing is important. For example, when one mass is pushed away from another when "Constant Size" changes, we are supposed to hear an alaert about how one mass is moved. I am not hearing this at all right now. Is that another bug?
  3. It would be ideal for the voicing response to be triggered in the same place as the interactive description response. But that separates it from the default Checkbox responses. And when we do that, the default checkbox responses override the custom responses in the utterance queue. How can we get around that? Note I am pretty sure this is why we aren't hearing the "Constant Size" information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants