Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposal of PhET-iO objects #158

Closed
jessegreenberg opened this issue Jun 28, 2019 · 3 comments
Closed

Disposal of PhET-iO objects #158

jessegreenberg opened this issue Jun 28, 2019 · 3 comments
Assignees
@jessegreenberg

Comments

@jessegreenberg
Copy link
Contributor

From #156, I am not certain how to test this. This sim is listed as a phet-io sim so it should probably be considered.

TANDEM: PhET-iO instrumented PhetioObject instances should be disposed.

@zepumph what should I be looking for for this?
@jessegreenberg
Copy link
Contributor Author

Oh, I just saw his documentation in implementation-notes.md

There are no dynamic pieces to this simulation, and as a result nothing is disposed. As a result no listeners need to be unlinked or removed.

So maybe this can just be closed. But perhaps there are things to think about still, so would be helpful for @zepumph to comment.

@jessegreenberg
Copy link
Contributor Author

I ran fuzz/memory tests with this sim in studio and saw similar memory profiles to #139, so I don't see evidence of a leak.

@zepumph
Copy link
Member

zepumph commented Jun 28, 2019

I think of tandem references as similar to axon listeners in terms of managing disposal. I don't think there is anything left here.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph