Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be boundary sounds for spin buttons, similar to mass location sliders? #177

Closed
emily-phet opened this issue Jun 18, 2019 · 9 comments

Comments

@emily-phet
Copy link

@terracoda brought up (from consultant discussion) that the spin buttons don't have a boundary sound, but the mass location sliders do.

@Ashton-Morris suggested a solution (having a gentle 'error' sound if spin buttons are pressed while inactive).

I think there is a deeper issue at play here - where visually the grab/drag of the mass objects and the press of the number spinner feel very different, but are actually very similar from the perspective of alternative input. This issue will come up across other sims...so I would prefer to hold off on digging deeply on this issue for this sim, and instead tackle it the next time we encounter it.

@terracoda
Copy link
Contributor

@emily-phet, I agree this is a deeper issue, and keep in mind for Gravity Force Lab regular, the position sliders and the mass sliders are exactly the same interaction (native HTML input type range).

We can explore this issue more deeply in that sim.

I would like to mention that for the position sliders, I also designed an alert that fires on the first try to go beyond an edge (beyond edge of track, or closer than closest to the other sphere), but I did not do a similar alert for the the mass controls. I've been thinking that might also be worth investigating. I'll open an issue for that in GFL regular.

@terracoda
Copy link
Contributor

Marking on hold so it is clear we will explore this idea further in GFL Regular.

@zepumph
Copy link
Member

zepumph commented Jul 1, 2019

Would it be helpful to transfer this issue to gravity-force-lab? Github makes that easy if we want to do that.

@terracoda
Copy link
Contributor

I think that would be fine.

@terracoda
Copy link
Contributor

terracoda commented Jul 1, 2019

@emily-phet, opened the issue. @emily-phet are you ok with moving to the other repo?

@zepumph zepumph transferred this issue from phetsims/gravity-force-lab-basics Sep 17, 2019
@zepumph
Copy link
Member

zepumph commented Sep 17, 2019

I moved it over to GFL.

@zepumph
Copy link
Member

zepumph commented Oct 8, 2019

@emily-phet now that we are working more on this sim. How would you like to proceed with this issue?

@emily-phet
Copy link
Author

@zepumph I think we've missed the moment for thoughtful exploration here - momentum is building towards wrapping up on the sound side. Pick up/Drop sounds are being added to the ruler, and I think (with the holiday's fast approaching) there isn't time to implement/iterate on this before end of quarter. I think we'll need to punt on this one, and take up the issue of consistent boundary sounds across 'slider' and 'slider-like' interactions in a future sim.

@zepumph
Copy link
Member

zepumph commented Nov 20, 2019

Alright, sounds good. I'm going to close this issue then, please reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants