-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that this sim works with mobile #119
Comments
@terracoda is reviewing content changes that rely on Focus and Blur events :-) |
@zepumph, I mentioned in phetsims/a11y-research#138 (comment) that I reviewed the design of the And with changing the Mass number spinners to sliders with |
phetsims/sun#499 got us most of the way there to mobile VO working with NumberPicker. But mobile VO is having a hard time with values in GFLB because the |
@jessegreenberg, I am confused, can't the step be 1, and the range be 1 to 10? |
@terracoda for sure, that would also solve the issue. The current implementation of this sim has both the physical model and NumberPicker units in kg so the range goes from 1000000000 - 10000000000. Only the display of the value is in billions of kg. Ideally, alternative input should work well for any range and step size, so phetsims/sun#509 was to see if it could be improved in common code. But a fix was committed in that issue and input is now working well with mobile VO. |
I just tested on an iPad Air 2 with VoiceOver and the sim works well. @zepumph @terracoda is there anything remaining for this issue? |
@jessegreenberg, perhaps not. We do have some general design changes that we are working on to not rely on focus events. I think these will be handled generally, though, so maybe not effect this issue. |
I'm going to unassign for now, but keep the blocking label on it. That will guarantee that we can have one more test either before or during dev testing. |
@jessegreenberg and @zepumph, I think we have addressed this issue, so unassigning myself, too. |
I will make sure to mention this in the dev testing issue I create today. Closing |
I'm unsure about the priority of this, but I know that we don't currently support number pickers in a11y, and that should be solved by phetsims/sun#499, but we should make sure to test this in general. Not sure what the priority is, but it should block publication.
The text was updated successfully, but these errors were encountered: