Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that this sim works with mobile #119

Closed
zepumph opened this issue Apr 15, 2019 · 10 comments
Closed

Make sure that this sim works with mobile #119

zepumph opened this issue Apr 15, 2019 · 10 comments

Comments

@zepumph
Copy link
Member

zepumph commented Apr 15, 2019

I'm unsure about the priority of this, but I know that we don't currently support number pickers in a11y, and that should be solved by phetsims/sun#499, but we should make sure to test this in general. Not sure what the priority is, but it should block publication.

@zepumph zepumph changed the title Make sure that this sim works with a11y Make sure that this sim works with mobile Apr 18, 2019
@terracoda
Copy link

@terracoda is reviewing content changes that rely on Focus and Blur events :-)

@terracoda
Copy link

@zepumph, I mentioned in phetsims/a11y-research#138 (comment) that I reviewed the design of the aria-valuetext and I assigned you a couple of questions to you from the design doc. We can discuss at our next meeting.

And with changing the Mass number spinners to sliders with aria-roledescription should mean we shouldn't have any mobile issues with this sim (hopefully).

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 8, 2019

phetsims/sun#499 got us most of the way there to mobile VO working with NumberPicker. But mobile VO is having a hard time with values in GFLB because the step attribute is so much smaller than the mass range (1/1000000000 of the range). phetsims/sun#509 was made for that issue.

@terracoda
Copy link

@jessegreenberg, I am confused, can't the step be 1, and the range be 1 to 10?

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 9, 2019

@terracoda for sure, that would also solve the issue. The current implementation of this sim has both the physical model and NumberPicker units in kg so the range goes from 1000000000 - 10000000000. Only the display of the value is in billions of kg. Ideally, alternative input should work well for any range and step size, so phetsims/sun#509 was to see if it could be improved in common code.

But a fix was committed in that issue and input is now working well with mobile VO.

@jessegreenberg
Copy link
Contributor

I just tested on an iPad Air 2 with VoiceOver and the sim works well. @zepumph @terracoda is there anything remaining for this issue?

@terracoda
Copy link

@jessegreenberg, perhaps not. We do have some general design changes that we are working on to not rely on focus events. I think these will be handled generally, though, so maybe not effect this issue.

@zepumph
Copy link
Member Author

zepumph commented May 17, 2019

I'm going to unassign for now, but keep the blocking label on it. That will guarantee that we can have one more test either before or during dev testing.

@zepumph zepumph removed their assignment May 17, 2019
@terracoda
Copy link

@jessegreenberg and @zepumph, I think we have addressed this issue, so unassigning myself, too.

@terracoda terracoda removed their assignment May 20, 2019
@zepumph
Copy link
Member Author

zepumph commented May 31, 2019

I will make sure to mention this in the dev testing issue I create today. Closing

@zepumph zepumph closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants