From a1b1dba7172e799f7529fc12ecf4a67662dc34fe Mon Sep 17 00:00:00 2001 From: zepumph Date: Tue, 18 Jun 2019 15:48:28 -0800 Subject: [PATCH] refactoring GravityForceLabAlertManager, and remove unused parameters/vars etc, update visibility annotations, https://github.com/phetsims/gravity-force-lab-basics/issues/134 --- js/gravity-force-lab-basics/view/GFLBAlertManager.js | 5 ++--- js/gravity-force-lab-basics/view/GFLBScreenView.js | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/js/gravity-force-lab-basics/view/GFLBAlertManager.js b/js/gravity-force-lab-basics/view/GFLBAlertManager.js index 6c8c014..628338b 100644 --- a/js/gravity-force-lab-basics/view/GFLBAlertManager.js +++ b/js/gravity-force-lab-basics/view/GFLBAlertManager.js @@ -20,10 +20,9 @@ define( require => { * @param {GFLBModel} model * @param {GFLBMassDescriber} massDescriber * @param {GFLBForceDescriber} forceDescriber - * @param {GFLBPositionDescriber} positionDescriber */ - constructor( model, massDescriber, forceDescriber, positionDescriber ) { - super( model, massDescriber, forceDescriber, positionDescriber, { + constructor( model, massDescriber, forceDescriber ) { + super( model, massDescriber, forceDescriber, { linkToScientificNotationProperty: false, // opt out of REGULAR specific linking // by default the REGULAR version is different from this because of scientific notation diff --git a/js/gravity-force-lab-basics/view/GFLBScreenView.js b/js/gravity-force-lab-basics/view/GFLBScreenView.js index 0f8c6c3..93d035d 100644 --- a/js/gravity-force-lab-basics/view/GFLBScreenView.js +++ b/js/gravity-force-lab-basics/view/GFLBScreenView.js @@ -90,7 +90,7 @@ define( require => { const positionDescriber = new GFLBPositionDescriber( model, mass1LabelString, mass2LabelString ); const forceDescriber = new GFLBForceDescriber( model, mass1LabelString, mass2LabelString, positionDescriber ); const massDescriber = new GFLBMassDescriber( model ); - const alertManager = new GFLBAlertManager( model, massDescriber, forceDescriber, positionDescriber ); + const alertManager = new GFLBAlertManager( model, massDescriber, forceDescriber ); // The PDOM screen summary const summaryNode = new GravityForceLabScreenSummaryNode( model, massDescriber, forceDescriber, positionDescriber, {