Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider uninstrumenting colors in next release #488

Open
arouinfar opened this issue Feb 8, 2024 · 0 comments
Open

Consider uninstrumenting colors in next release #488

arouinfar opened this issue Feb 8, 2024 · 0 comments

Comments

@arouinfar
Copy link
Contributor

arouinfar commented Feb 8, 2024

In phetsims/scenery#1607 we discovered that colors customized in Studio are overwritten when switching between color profiles. This issue will be addressed by an MR, but while investigating we saw that GAO has these instrumented colors:

image

I don't think the design team made an explicit decision to expose these colors to clients, and it probably snuck in during the early days of instrumenting colors. We wouldn't typically instrument these colors, so let's consider uninstrumenting them in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant