Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6: Unexpected token: export in record wrapper with ?localFile #480

Open
samreid opened this issue Dec 24, 2022 · 0 comments
Open

1.6: Unexpected token: export in record wrapper with ?localFile #480

samreid opened this issue Dec 24, 2022 · 0 comments

Comments

@samreid
Copy link
Member

samreid commented Dec 24, 2022

Gravity and Orbits 1.6 is affected by phetsims/ph-scale#265.

@kathy-phet said:

@samreid - Does this fix need an issue in GAO, to track as a potential MR or republish? e.g. is this bug in GAO?

I replied:

This bug occurs in Gravity and Orbits but I do not think it warrants an eager maintenance release. I don't think we have documented the localFile query parameter for client usage--it is more for our own team testing.

@kathy-phet said:

That’s ok, but can you make a tracking issue in GAO so we can track it.

If we decide this is worth the time to fix, there is a commit in phetsims/ph-scale#265 which can be cherry-picked.

This is not a problem in master.

@samreid samreid changed the title Unexpected token: export in record wrapper with ?localFile 1.6: Unexpected token: export in record wrapper with ?localFile Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant