Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to hide screen icons as instructed #451

Closed
Tracked by #841
KatieWoe opened this issue Sep 28, 2022 · 3 comments
Closed
Tracked by #841

Unable to hide screen icons as instructed #451

KatieWoe opened this issue Sep 28, 2022 · 3 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#838, seen on Win 11 Chrome.
The element gravityAndOrbits.general.model.screens.isUserNavigatableProperty is given in the model as being able to hide screen icons in the nav bar. However, this element does not seem to exist. I suspect gravityAndOrbits.general.model.screens.isUserNavigableProperty should be the element instead.

@arouinfar
Copy link
Contributor

Thanks @KatieWoe. I can take care of fixing this, but I'd like to wait and see how many issues require editing the PhET-iO Guide so I can group everything into one commit. Related issues #450 #452.

@zepumph
Copy link
Member

zepumph commented Oct 4, 2022

@samreid and I are cruising through issues linked in the GAO rc, and fixed this guy. Ready for cherry pick.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Oct 6, 2022

This is fixed in RC3

@KatieWoe KatieWoe closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants