Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline appears around scenes #446

Closed
Tracked by #841
Nancy-Salpepi opened this issue Sep 28, 2022 · 4 comments
Closed
Tracked by #841

Outline appears around scenes #446

Nancy-Salpepi opened this issue Sep 28, 2022 · 4 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
macOS 12.6

Browser
Safari 16.0

Problem description
For phetsims/qa#838, when I hover the mouse over different scenes an outline appears. This issue is related to phetsims/sun#772 and has been addressed by @jbphet on master. Assigning this issue to him as well, so that he can link the commit.

Visuals

Screen Shot 2022-09-27 at 3 10 51 PM

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Gravity and Orbits‬ URL: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.6.0-rc.1/phet/gravity-and-orbits_all_phet.html Version: 1.6.0-rc.1 2022-09-27 17:23:51 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36 Language: en-US Window: 1815x925 Pixel Ratio: 1.3333333730697632/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@jbphet
Copy link
Contributor

jbphet commented Sep 28, 2022

This is fixed in master, and there are two commits that should both be picked up to resolve it in a release branch. They are:

I'm going to discuss some of these changes with another dev early next week, and I'll amend this if anything changes, so I'll leave the issue assigned to myself for now.

@jbphet
Copy link
Contributor

jbphet commented Oct 3, 2022

The changes are finalized. I've added some documentation but didn't change the functionality any further, so the two commits listed above should do the trick. Assigning to @samreid, since I believe he is working on the release of this sim.

@jbphet jbphet removed their assignment Oct 3, 2022
@arouinfar
Copy link
Contributor

Thanks @jbphet looks good in master.

@Nancy-Salpepi
Copy link
Author

Looks good on master and in 1.6.0-rc.3! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants