Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launched sim performance severely affected in Safari #421

Closed
Nancy-Salpepi opened this issue Jun 24, 2022 · 5 comments
Closed

Launched sim performance severely affected in Safari #421

Nancy-Salpepi opened this issue Jun 24, 2022 · 5 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip) and iMac Desktop

Operating System
12.4 and 10.15.7

Browser
Safari

Problem description
For phetsims/qa#816, when I launch the sim in studio, after checking a few checkboxes in the Model screen, the sim will basically come to a standstill and then sputter forward ~every second.

  • This will only happen the first time the sim is launched. The issue won't repeat itself unless I clear my history
  • Not seen with mac + chrome

Steps to reproduce

  1. In studio, go to the Model screen
  2. Press the Preview Sim button
  3. In the launched sim, check the path and velocity checkboxes
  4. Press Play button

Visuals

performance.mov
@samreid
Copy link
Member

samreid commented Jul 13, 2022

I tried on Macbook Air M1 with Safari Version 15.2 (17612.3.6.1.6). I emptied the cache and followed the instructions above, but the sim preview was a fast 60fps each time. I'm on MacOS 12.1. Same good behavior and local copy and on the dev version. @Nancy-Salpepi can you still replicate the problem? What safari versions are you using? Does it happen in the previous version or on phettest/master? We may need to collaborate to investigate this.

@samreid samreid assigned Nancy-Salpepi and unassigned samreid Jul 13, 2022
@Nancy-Salpepi
Copy link
Author

@samreid I was able to reproduce this issue following the above steps in version 1.6, 1.5 and on master using 2 different macs:
MacBook Air m1 macOS 12.4 + safari Version 15.5 (17613.2.7.1.8)
iMac macOS 10.15.7 + safari Version 15.5 (15613.2.7.1.9)

Perhaps this has to do with the latest safari version?

@samreid
Copy link
Member

samreid commented Jul 27, 2022

Please see notes in phetsims/friction#278 (comment) about a potential flaw in safari 15.3 through 15.5. @Nancy-Salpepi can you please test this issue in 15.6?

@Nancy-Salpepi
Copy link
Author

@samreid all looks good with Safari 15.6. I was unable to reproduce in 4 attempts.

@zepumph
Copy link
Member

zepumph commented Jul 27, 2022

Excellent! I'm going to close this, @samreid please reopen if there are any other thoughts. Thanks all!

@zepumph zepumph closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants