Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items may not be returned, even with Return Object button #332

Closed
KatieWoe opened this issue May 29, 2020 · 3 comments
Closed

Items may not be returned, even with Return Object button #332

KatieWoe opened this issue May 29, 2020 · 3 comments

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 10
Browser
Firefox
Problem description
For phetsims/qa#505. Found in published version. Related to #241. May be most preferable option, in which case, please close.
It is possible to permanently loose an object, so that the Return Object button does not bring it back. If this happens the Return Object button will keep popping up, but still will not return the missing object.
Steps to reproduce

  1. Pull up any screen/scene (I find it easier to do on the second screen)
  2. Zoom out all the way
  3. Turn on the Velocity checkbox
  4. Manipulate the velocity so that the orbiting object will shoot off screen
  5. Once it has, pause the sim
  6. Manipulate the large object's velocity so that it will shoot off screen next
  7. Play sim again
  8. Once the large object is gone, press the Return Object button

Visuals
moonwontreturn

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Gravity and Orbits‬
URL: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-dev.10/phet/gravity-and-orbits_en_phet.html?colorProfile=projector
Version: 1.2.0-dev.10 2020-05-26 17:36:54 UTC
Features missing: touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0
Language: en-US
Window: 1536x750
Pixel Ratio: 2.5/1
WebGL: WebGL 1.0
GLSL: WebGL GLSL ES 1.0
Vendor: Mozilla (Mozilla)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@samreid
Copy link
Member

samreid commented Jun 8, 2020

In discussion with @arouinfar, we agreed that since this occurs in the published version it will not block dev releases, but it should be investigated before RC.

@samreid samreid removed their assignment Jun 11, 2020
@samreid samreid self-assigned this Aug 7, 2020
@samreid
Copy link
Member

samreid commented Aug 15, 2020

This simulation records a new set of "initial conditions" when you update a position or velocity of a body. It appears that "Return Objects" returns them to their recorded "initial conditions" instead of the simulation starting state. Should we change the "Return Objects" button so that it returns objects to their simulation starting state? @arouinfar what do you recommend?

@arouinfar
Copy link
Contributor

After playing with this a bit more, I think the what @KatieWoe presented is more of an edge case.

There's a lot of value in restoring the objects to the latest "initial conditions". It's likely that a user's custom orbit will lead to objects being lost off-screen. I think it's a better UX for the Return Objects button to restore the customized "initial conditions" so the experiment can be repeated.

At times, the behavior can be weird (as @KatieWoe demonstrated) but overall I think the current behavior is the better approach. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants