Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in CONTROL_PANEL_OPTIONS ? #197

Closed
pixelzoom opened this issue Nov 9, 2015 · 2 comments
Closed

bug in CONTROL_PANEL_OPTIONS ? #197

pixelzoom opened this issue Nov 9, 2015 · 2 comments
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

Related to code review #173.

In GravityAndOrbitsConstants:

    CONTROL_PANEL_OPTIONS: {
      ...
      fill: GravityAndOrbitsColorProfile.panelBackgroundProperty
    },

This looks like a bug.
Shouldn't it be GravityAndOrbitsColorProfile.panelBackgroundProperty.get()?
@pixelzoom
Copy link
Contributor Author

Or perhaps I don't understand how the color profile works. If that's the case, please describe.

@pixelzoom pixelzoom changed the title bug in CONTROL_PANEL_OPTIONS bug in CONTROL_PANEL_OPTIONS ? Nov 9, 2015
@aaronsamuel137
Copy link
Contributor

It's not a bug. Scenery now supports Property as an allowed type for fills. Passing the property here makes so the panel color will update automatically when the projector mode is turned on.

Let me know if you have more questions here, otherwise feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @aaronsamuel137 @ariel-phet