Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider ditching GRAPHING_LINES/Graph #99

Closed
pixelzoom opened this issue Nov 1, 2018 · 1 comment
Closed

consider ditching GRAPHING_LINES/Graph #99

pixelzoom opened this issue Nov 1, 2018 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

... because this.lines is not used, and there's not much else to it.

Related to code review #43.
@pixelzoom pixelzoom self-assigned this Nov 1, 2018
@pixelzoom
Copy link
Contributor Author

I now recall why I didn't do this in the first place. GRAPHING_LINES/GraphNode (which we definitely need to use) requires GRAPHING_LINES/Graph. So no changes here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom