From 33868ecdff9d42f7a863c5ec4ecf6810156bb70f Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Thu, 4 Mar 2021 18:46:11 -0700 Subject: [PATCH] move noRealRootsNode.visibleProperty phetioReadOnly:false from overrides.js to code, #148 --- js/graphing-quadratics-phet-io-overrides.js | 3 --- js/standardform/view/NoRealRootsNode.js | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/js/graphing-quadratics-phet-io-overrides.js b/js/graphing-quadratics-phet-io-overrides.js index 09989449..6b1d364a 100644 --- a/js/graphing-quadratics-phet-io-overrides.js +++ b/js/graphing-quadratics-phet-io-overrides.js @@ -217,9 +217,6 @@ window.phet.preloads.phetio.phetioElementsOverrides = "graphingQuadratics.standardFormScreen.view.leftPointToolNode.visibleProperty": { "phetioFeatured": true }, - "graphingQuadratics.standardFormScreen.view.noRealRootsNode.visibleProperty": { - "phetioReadOnly": true - }, "graphingQuadratics.standardFormScreen.view.rightPointToolNode.visibleProperty": { "phetioFeatured": true }, diff --git a/js/standardform/view/NoRealRootsNode.js b/js/standardform/view/NoRealRootsNode.js index 5fe5296f..b2858239 100644 --- a/js/standardform/view/NoRealRootsNode.js +++ b/js/standardform/view/NoRealRootsNode.js @@ -41,8 +41,8 @@ class NoRealRootsNode extends Node { // phet-io tandem: Tandem.REQUIRED, - phetioDocumentation: 'displays NO REAL ROOTS when the interactive quadratic has no real roots' - + phetioDocumentation: 'displays NO REAL ROOTS when the interactive quadratic has no real roots', + visiblePropertyOptions: { phetioReadOnly: true } // because visibility is derived below }, options ); const textNode = new Text( graphingQuadraticsStrings.noRealRoots, {