Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using PropertyFractionNode (common) #130

Closed
amanda-phet opened this issue Jul 29, 2019 · 1 comment
Closed

Consider using PropertyFractionNode (common) #130

amanda-phet opened this issue Jul 29, 2019 · 1 comment
Labels
type:wontfix

Comments

@amanda-phet
Copy link
Contributor

Any sim that uses a fraction in a display might want to consider using (and modifying, if needed) the new fraction common code that was added due to phetsims/fractions-intro#7 .
@pixelzoom pixelzoom mentioned this issue Aug 7, 2019
Closed
@pixelzoom
Copy link
Contributor

I have investigated. The advantage to doing this is almost negligible, and the amount of work is large. Even if there were some a11y or PhET-iO advantage, those features should be addressed for equations in general, not just fractions.

So I'm going to close this as "won't fix". @amanda-phet feel free to reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @amanda-phet