Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox anti-aliasing allows obscured lines and equations to be seen #125

Closed
KatieWoe opened this issue Feb 13, 2019 · 10 comments
Closed

Firefox anti-aliasing allows obscured lines and equations to be seen #125

KatieWoe opened this issue Feb 13, 2019 · 10 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#287 and phetsims/qa#286
Only seen on firefox Mac 10.14 so far. It seems that sometimes, when a line or equation is "hidden" behind another, it can be seen somewhat. Very minor. This was first noticed with the green text of the y=x line behind the active line seen here (rtl not needed). Also seen in the game when a green line is layered over a black line.
pastedimage

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 13, 2019

My best guess is that Firefox text anti-aliasing has translucent pixels around the edges, which would cause what is behind it to show through. @jonathanolson does that sound plausible, or do you an explanation?

In any case, my recommendation is to ignore this. If anything, it's kind of nice, because it cues you to the fact that there's more than one line in the same location.

@pixelzoom
Copy link
Contributor

@KatieWoe clarification about the title of this issue, which is "Firefox may have different line sizes". This doesn't seem to have anything to do with line, it's the equation on the line. Is that true, or am I missing something subtle in the screenshot above?

@KatieWoe
Copy link
Contributor Author

I meant line as in both the lines and the lines that make up text.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 13, 2019

Ah yes, much more difficult to see (for me) with the line. Below is a screenshot using Digital Color Meter to zoom in on the line, and there's clear some green around the edges. This still looks like a symptom of how Firefox does anti-aliasing.

screenshot_1054

@KatieWoe
Copy link
Contributor Author

I honestly only noticed that the line looked a bit more fuzzy, not the color.

@pixelzoom
Copy link
Contributor

There's a little bit of this in every browser that I've looked at. For example:

macOS + Chrome with y = x off:

screenshot_1057

macOS + Chrome with y = x on:

screenshot_1058

When y = x is on, you can clearly see some green in the 'y' shown in Digital Color Meter.

@KatieWoe
Copy link
Contributor Author

Overall, I would agree that this doesn't need anything done. Just documenting.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 13, 2019

I talked with @jonathanolson about this on Slack. It's definitely anti-aliasing. It's probably more pronounced on Firefox because it uses a different rendering engine. Using a different scenery renderer option for lines and equations might change the behavior. But I'd have to investigate, and that doesn't seem like time well-spent, because this issue is a (very minor) cosmetic blemish and causes no usability issues. So I'm recommending that we close this as "won't fix".

@amanda-phet your opinion?

@pixelzoom pixelzoom changed the title Firefox may have different line sizes Firefox anti-aliasing allows obscured lines and equations to be seen Feb 13, 2019
@amanda-phet
Copy link
Contributor

amanda-phet commented Feb 14, 2019

I agree that it's almost a benefit, as @pixelzoom says, because it indicates that there are two layered equations/lines. Thank you for diving into the cause, and since it is an anti-aliasing issue and not something else (like the other string issues I was watching) I am happy to leave it as-is.

Thanks @KatieWoe for finding and documenting.

@pixelzoom
Copy link
Contributor

@KatieWoe thanks again for reporting.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants