Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated positionProperty listener #378

Closed
pixelzoom opened this issue Mar 15, 2022 · 1 comment
Closed

Duplicated positionProperty listener #378

pixelzoom opened this issue Mar 15, 2022 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

For #374

LensNode, MirrorNode, and ProjectionScreenNode all have this listener:

    lens.positionProperty.link( position => {
      this.translation = modelViewTransform.modelToViewPosition( position );
    } );

Are there others? Should I factor out a "positionable" model element and Node subclass? It might be more trouble than it's worth.

@pixelzoom pixelzoom self-assigned this Mar 15, 2022
@pixelzoom pixelzoom changed the title Factor out "positionable" model element and Node subclass? Duplicted positionProperty listener Mar 15, 2022
@pixelzoom pixelzoom changed the title Duplicted positionProperty listener Duplicated positionProperty listener Mar 15, 2022
@pixelzoom
Copy link
Contributor Author

Investigated... This is definitely not worth the trouble. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant