Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UI sound. #236

Closed
pixelzoom opened this issue Oct 14, 2021 · 5 comments
Closed

Add support for UI sound. #236

pixelzoom opened this issue Oct 14, 2021 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 14, 2021

Added at 10/14/21 quarterly planning meeting.

The plan is to add support for standard (common-code) UI components. There is no plan to add sound (or do sound design) for sim-specific components or actions (like dragging the lens, object, light source, or projection screen).

@pixelzoom
Copy link
Contributor Author

This sim has 3 sliders, which are a central part of the UI. Reminder that sliders will not have sound until phetsims/sun#697 is addressed.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 8, 2022

Slider sound has been implemented by @jbphet, and it seems sufficient to support this sim. So support for UI sound is now complete and ready for review.

@arouinfar
Copy link
Contributor

@pixelzoom the sim sounds good in master. The only thing that is potentially missing is a sound related to the tools and toolbox. In Waves Intro, there is a sound whenever a tool is picked up and released (including when removing from/returning to toolbox). I doubt this sound has been generalized, but it sounds very similar to the toggle button sound so perhaps we could use that instead.

@kathy-phet @ariel-phet what do you think? Should there be a sound related to picking up/releasing the tools? If so, what do you recommend we use?

@arouinfar arouinfar assigned ariel-phet and kathy-phet and unassigned arouinfar Mar 11, 2022
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Mar 11, 2022

From the first comment in this issue:

There is no plan to add sound (or do sound design) for sim-specific components or actions (like dragging the lens, object, light source, or projection screen).

Rulers and position markers are in that same category of "sim-specific components".

But if you want to revisit that decision...

  • Do we need a sound for press (and release?) of a tool, and its toolbox icon?
  • Do we need a sound for press (and release?) on an Object?
  • Do we need a sound for press (and release?) on the Projection Screen?

@arouinfar
Copy link
Contributor

Thanks for the reminder @pixelzoom! I'm comfortable with sticking with our earlier decision -- I just couldn't remember if it had been discussed or not. In that case, I think this issue is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants