Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate rendering with shuffleListeners query parameter #145

Closed
veillette opened this issue Jul 29, 2021 · 2 comments
Closed

Inaccurate rendering with shuffleListeners query parameter #145

veillette opened this issue Jul 29, 2021 · 2 comments

Comments

@veillette
Copy link
Contributor

veillette commented Jul 29, 2021

While working on #129, I noticed that having the queryParameter ShuffleListeners , lead to inaccurate rendering with the curveType button. The image position and scale as well as the rays position do not update correctly, when toggling between convex and concave optic.

@veillette veillette self-assigned this Jul 29, 2021
@veillette veillette mentioned this issue Jul 30, 2021
@pixelzoom pixelzoom changed the title QueryParameter ?ShuffleListeners and changing curveType QueryParameter ?shuffleListeners and changing curveType Sep 16, 2021
@pixelzoom pixelzoom added the type:bug Something isn't working label Sep 16, 2021
@pixelzoom
Copy link
Contributor

It would not be tragic if this sim did not support ?shuffleListeners. So I'm going to unassign this for now, and we can decide whether we want to spend time on it when we get closer to public deployment.

@pixelzoom pixelzoom added status:on-hold and removed type:bug Something isn't working labels Sep 18, 2021
@pixelzoom pixelzoom changed the title QueryParameter ?shuffleListeners and changing curveType Inaccurate rendering with shuffleListeners query parameter Sep 18, 2021
@pixelzoom
Copy link
Contributor

This has sorted itself out after all the changes and refactoring. I can no longer reproduce by switching between concave and convex lens types. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants