From e85490b88342855bf91bbc9e63e8b34a94861830 Mon Sep 17 00:00:00 2001 From: zepumph Date: Thu, 5 Aug 2021 12:58:11 -0400 Subject: [PATCH] review comments, https://github.com/phetsims/geometric-optics/issues/154 --- js/common/model/Target.js | 2 +- js/lens/model/Spotlight.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/js/common/model/Target.js b/js/common/model/Target.js index c15136c0..2e0520d4 100644 --- a/js/common/model/Target.js +++ b/js/common/model/Target.js @@ -22,7 +22,7 @@ class Target extends EnabledComponent { /** * @param {Property.} objectPositionProperty - position of the object/source * @param {Optic} optic - model of the optic - * @param {Property.} representationProperty + * @param {Property.} representationProperty * @param {Tandem} tandem */ constructor( objectPositionProperty, diff --git a/js/lens/model/Spotlight.js b/js/lens/model/Spotlight.js index 5e11bc5f..f09cd652 100644 --- a/js/lens/model/Spotlight.js +++ b/js/lens/model/Spotlight.js @@ -46,6 +46,7 @@ class Spotlight { // determine the shape intersection of the screen and spotlight // @public (read-only) {Property.} + // REVIEW: This is a bit vague, perhaps intersectionShapeProperty? At first I thought it was the shape of the spotlight source itself, and wondered why it was in the model. this.shapeProperty = new DerivedProperty( [ screenPositionProperty, optic.positionProperty,