Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio tree for geometric-optics-basics is empty except for phetioEngine #4

Closed
pixelzoom opened this issue Feb 23, 2022 · 2 comments
Closed
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 23, 2022

While attempting to test #3, @arouinfar ran into problems. That began a series of comments that are not related to that issue. So I'm moving those comments here.


@arouinfar said:

@pixelzoom did you forget to push to master? I've pulled all and cleared the cache, but the Studio tree for geometric-optics-basics is empty except for phetioEngine.

@samreid said:

This may be due to a phet-io problem. I'm seeing that the simStarted event is not processing properly, so there is an error in the console. Probably not a geometric-optics-specific problem. Tagging @zepumph in case he has ideas.

Specifically, the simStarted event is going nowhere because phet.phetio.dataStream is coming up falsy in the guard.

@arouinfar said:

Thanks @samreid looks like it is indeed a general problem. I tried a few other sims and they're all showing the same empty tree.

@samreid said:

Thanks, I moved it to a side issue. (EDIT: see https://github.com/phetsims/phet-io/issues/1845)

@samreid said:

OK I pushed a fix in the issue. @arouinfar can you please pull and test?

@zepumph
Copy link
Member

zepumph commented Feb 23, 2022

Since https://github.com/phetsims/phet-io/issues/1845 is closed, most like this can be also.

@arouinfar
Copy link
Contributor

The tree is no longer empty in master, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants