Geometric Optics: Basics - publish 1.2

[pixelzoom]

From 10/27/2022 PhET-iO meeting...

Because #25 (Geometric Optics: Basics - Publish 1.2 with PhET-iO, UI Sound, Alt Input) is not going to be completed for awhile, we're going to move ahead with publishing a PhET-brand version.

I'll review issues, then get this going at the beginning of next week.

[pixelzoom]

We have a little version numbering problem to work out first. To keep the version numbers in sync between GO and GO:Basics, we had previously bumped GO:B to 1.2 (skipped 1.0 and 1.1). And two 1.2 dev versions of GO:B have been published for #25.

Now we'll presumably want to publish GO:Basics with version 1.1, so that 1.2 will still be for #25.

I'll ruminate on how to address this.

[pixelzoom]

Correction... GO is currently at 1.1 on the PhET website. So we'd like GO:B to also be 1.1.

[pixelzoom]

Two 1.2 dev versions have been published: 1.2.0-dev.1 (4/6/22) and 1.2.0-dev.2 (4/15/22). My first thought was to delete those dev versions, and revert GO:B package.json to "1.1.0", to be in-sync with GO.

Unfortunately, those 1.2 dev versions are referenced in GitHub issues. For example, 1.2.0-dev.2 is mentioned in issue #19 that was created by QA. And I don't know if links have been shared outside of PhET.

If we don't care about version numbers being in-sync, we could do nothing. The result will be:

• GO:B brand=phet-io will be 1.2
• GO:B brands=phet,phet-io will be 1.3
• GO brands=phet,phet-io will be 1.2

If we want the version numbers to stay in-sync, then I recommend:

• publish GO:B with 1.2
• bump GO to 1.3, skipping 1.2
• publish GO and GO:B for PhET-iO with 1.3

@arouinfar @kathy-phet how do you want to proceed?

[pixelzoom]

In phetsims/scenery-phet#769 (comment), I discovered a huge increase in memory for this (and other ) sims. Publication is blocked until this increase is investigated and explained.

[arouinfar]

If we want the version numbers to stay in-sync, then I recommend:

• publish GO:B with 1.2
• bump GO to 1.3, skipping 1.2
• publish GO and GO:B for PhET-iO with 1.3

Sounds good to me @pixelzoom. Let's proceed with GO:B 1.2 and re-sync the versions for the PhET-iO publication.

[samreid]

(At least part of the) memory issue is due to phetsims/chipper#1323

[pixelzoom]

I see some progress in phetsims/chipper#1323. But then the issue was passed on to QA to vet the changes, without clarification of what to do next. So I'm going to assume that work on GO:B is still blocked. @kathy-phet @arouinfar FYI.

[samreid]

I feel it’s unblocked and testing can happen during GO:B dev test.

[kathy-phet]

I agree with Sam, let's continue with putting in a GO:B dev test (1.2). And I agree with 1.2 for GO:B, then resync with 1.3 PhET-iO on both Thanks!

[pixelzoom]

The fact that we're not building things for PhET's "supported platforms" sure feels like it should be blocking - see phetsims/chipper#1323 (comment). But OK... I'll proceed.

[pixelzoom]

Dev test submitted on 10/31/2022 🎃 :

• Dev Test - Geometric Optics: Basics 1.2.0-dev.3 qa#847

Dev test was completed on 11/7/2022. There was 1 requirements change (#32), 2 common-code problems (#29, phetsims/scenery#1503), and 0 sim-specific issues. Next steps are blocked until the common-code issues are addressed.

[pixelzoom]

11/10/2022 check-in meeting, next steps:

• address Graphics artifacts in Safari 16 scenery#1503
• address CT: Assertion failed: no item found that has focus #33
• create 1.2 release branch and start the RC process

[pixelzoom]

RC test submitted on 11/18/2022:

• RC Test: Geometric Optics: Basics 1.2.0-rc.1 qa#858

RC test was completed on 11/29/2022. No sim-specific problems were found. 2 common-code problems were found, but they were determined to be non-blocking; they affect multiple sims and will be addressed via a future maintenance release. So we're ready to publish 1.2.0.

[pixelzoom]

11/29/2022: I updated QA credits for #28, which required publishing 1.2.0-rc.2 before I could publish a production version. So 1.2.0-rc.2 did not go through QA, and I spot-checked the QA credits.

[pixelzoom]

1.2.0 was published on 11/30/2022.