Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ProfileColorProperty references out of Particle. #218

Closed
pixelzoom opened this issue Mar 19, 2024 · 1 comment
Closed

Move ProfileColorProperty references out of Particle. #218

pixelzoom opened this issue Mar 19, 2024 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

In Particle.ts:

  public readonly colorProperty: ProfileColorProperty;
  public readonly highlightColorProperty: ProfileColorProperty;

Investigate whether these can be moved out of Particle. They are references that are passed in via the constructor, but in light of PhET-iO instrumentation and how that will impact Particle, it would be wise to move them elsewhere if possible.

@pixelzoom pixelzoom self-assigned this Mar 19, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented May 7, 2024

This was unnecessary for accomplishing #231 (PhET-iO instrumentation of particles). The colors are provided by the constructors for subclasses HeavyParticle, LightParticle, DiffusionParticle1, and DiffusionParticle2. So the colors do not need to be serialized.

@pixelzoom pixelzoom removed their assignment May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant