From bd3f46512881130773c8abbb1664840c424d925e Mon Sep 17 00:00:00 2001 From: Marla Schulz Date: Tue, 13 Sep 2022 12:36:47 -0700 Subject: [PATCH] Rename Separators to Deprecated and Dividers to Separators, see: https://github.com/phetsims/scenery/issues/1448 --- doc/implementation-notes.md | 2 +- js/diffusion/view/DataAccordionBox.js | 4 ++-- js/diffusion/view/DiffusionControlPanel.js | 6 +++--- js/ideal/view/IdealControlPanel.js | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/implementation-notes.md b/doc/implementation-notes.md index fc5d1c84..7df5ff63 100644 --- a/doc/implementation-notes.md +++ b/doc/implementation-notes.md @@ -18,7 +18,7 @@ In addition to this document, you are encouraged to read: This section defines terminology that you'll see used throughout the internal and external documentation. Skim this section once, and refer back to it as you explore the implementation. Much of the terminology for this sim is identified by labels that are visible in the user interface (Stopwatch, -Collision Detector, Particle Flow Rate, Divider, ...) and those terms are not included here. +Collision Detector, Particle Flow Rate, Separator, ...) and those terms are not included here. Here's the (relatively short) list of terms that might be unclear: diff --git a/js/diffusion/view/DataAccordionBox.js b/js/diffusion/view/DataAccordionBox.js index ffda9fef..5d1e733d 100644 --- a/js/diffusion/view/DataAccordionBox.js +++ b/js/diffusion/view/DataAccordionBox.js @@ -11,7 +11,7 @@ import merge from '../../../../phet-core/js/merge.js'; import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2.js'; import { HBox, Text } from '../../../../scenery/js/imports.js'; import AccordionBox from '../../../../sun/js/AccordionBox.js'; -import VSeparator from '../../../../sun/js/VSeparator.js'; +import VSeparatorDeprecated from '../../../../sun/js/VSeparatorDeprecated.js'; import Tandem from '../../../../tandem/js/Tandem.js'; import GasPropertiesColors from '../../common/GasPropertiesColors.js'; import GasPropertiesConstants from '../../common/GasPropertiesConstants.js'; @@ -57,7 +57,7 @@ class DataAccordionBox extends AccordionBox { const rightDataNode = new DiffusionDataNode( rightData, modelViewTransform ); // Vertical separator, analogous to the container's divider - const separator = new VSeparator( 75, { + const separator = new VSeparatorDeprecated( 75, { lineWidth: 2, stroke: GasPropertiesColors.dividerColorProperty } ); diff --git a/js/diffusion/view/DiffusionControlPanel.js b/js/diffusion/view/DiffusionControlPanel.js index 763506a0..4bbf91c5 100644 --- a/js/diffusion/view/DiffusionControlPanel.js +++ b/js/diffusion/view/DiffusionControlPanel.js @@ -10,7 +10,7 @@ import BooleanProperty from '../../../../axon/js/BooleanProperty.js'; import ReadOnlyProperty from '../../../../axon/js/ReadOnlyProperty.js'; import merge from '../../../../phet-core/js/merge.js'; import { VBox } from '../../../../scenery/js/imports.js'; -import HSeparator from '../../../../sun/js/HSeparator.js'; +import HSeparatorDeprecated from '../../../../sun/js/HSeparatorDeprecated.js'; import Panel from '../../../../sun/js/Panel.js'; import Tandem from '../../../../tandem/js/Tandem.js'; import GasPropertiesColors from '../../common/GasPropertiesColors.js'; @@ -81,13 +81,13 @@ class DiffusionControlPanel extends Panel { tandem: options.tandem.createTandem( 'settingsNode' ) } ), - // Remove/Reset Divider button, centered + // Remove/Reset Separator button, centered new FixedWidthNode( contentWidth, dividerToggleButton, { align: 'center' } ), // ------------ - new HSeparator( contentWidth, { + new HSeparatorDeprecated( contentWidth, { stroke: GasPropertiesColors.separatorColorProperty, maxWidth: contentWidth } ), diff --git a/js/ideal/view/IdealControlPanel.js b/js/ideal/view/IdealControlPanel.js index d15980ee..5fb26667 100644 --- a/js/ideal/view/IdealControlPanel.js +++ b/js/ideal/view/IdealControlPanel.js @@ -12,7 +12,7 @@ import NumberProperty from '../../../../axon/js/NumberProperty.js'; import ReadOnlyProperty from '../../../../axon/js/ReadOnlyProperty.js'; import merge from '../../../../phet-core/js/merge.js'; import { VBox } from '../../../../scenery/js/imports.js'; -import HSeparator from '../../../../sun/js/HSeparator.js'; +import HSeparatorDeprecated from '../../../../sun/js/HSeparatorDeprecated.js'; import Panel from '../../../../sun/js/Panel.js'; import Tandem from '../../../../tandem/js/Tandem.js'; import GasPropertiesColors from '../../common/GasPropertiesColors.js'; @@ -73,7 +73,7 @@ class IdealControlPanel extends Panel { maxWidth: contentWidth, tandem: options.tandem.createTandem( 'holdConstantControl' ) } ) ); - children.push( new HSeparator( contentWidth, { + children.push( new HSeparatorDeprecated( contentWidth, { stroke: GasPropertiesColors.separatorColorProperty, maxWidth: contentWidth } ) );