Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some strings are in friction-strings_en.json and some are in FrictionA11yStrings.js #66

Closed
samreid opened this issue Feb 6, 2018 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Feb 6, 2018

Discovered in #64

Some a11y strings are in the json:

  "moveBookHeader": {
    "value": "Move Book"
  },
  "moveBook": {
    "value": "Move book"
  },
  "moveInSmallerSteps": {
    "value": "Move in smaller steps"
  }

and several are in FrictionA11yStrings.js.

@jessegreenberg should these be consolidated? Is there a good reason to keep them separate?

@jessegreenberg
Copy link
Contributor

The separation is intentional. A11y related strings in the json are visible in the keyboard help dialog, so it is important that they are translatable. Strings in FrictionA11yStrings.js are only available for a screen reader user. In general these strings are not translatable yet because we want to enhance the Rosetta UI by adding context for these strings for translators. We also want some broader community feedback about a11y strings before submitting them for i18n, which we hope to receive as more sims are instrumented with a11y.

Reassigning to @samreid in case there are other questions.

@samreid
Copy link
Member Author

samreid commented Feb 7, 2018

That makes sense to me, thanks!

@samreid samreid closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants