Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples.md has a typo in a phetioID #332

Closed
Tracked by #899
arouinfar opened this issue Jan 31, 2023 · 3 comments
Closed
Tracked by #899

Examples.md has a typo in a phetioID #332

arouinfar opened this issue Jan 31, 2023 · 3 comments
Labels
design:phet-io status:blocks-sim-publication status:ready-for-review

Comments

@arouinfar
Copy link
Contributor

For phetsims/qa#886.

@stemilymill found a typo in the examples doc. There's a phetioID that currently begins with iction instead of friction. There isn't currently any validation for the phetioIDs shared in client documentation, but it's a feature we've considered in https://github.com/phetsims/phet-io-sim-specific/issues/21.

@zepumph I'll take care of the typo in master and then pass it over to you for cherry-picking.
@arouinfar arouinfar self-assigned this Jan 31, 2023
@arouinfar
Copy link
Contributor Author

Fix committed and referenced above, ready for cherry-picking @zepumph.

@arouinfar arouinfar assigned zepumph and unassigned arouinfar Jan 31, 2023
@zepumph zepumph removed their assignment Feb 1, 2023
@jessegreenberg
Copy link
Contributor

Cherry-pick into 1.6 SHAs done. I don't know how to test this change and will lean on QA to verify.

@jessegreenberg jessegreenberg mentioned this issue Feb 8, 2023
Closed
27 tasks
@Nancy-Salpepi
Copy link

Looks good in rc.3. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:phet-io status:blocks-sim-publication status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jessegreenberg @zepumph @arouinfar @Nancy-Salpepi