Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things should be read that aren't #269

Closed
KatieWoe opened this issue Oct 27, 2021 · 7 comments
Closed

Things should be read that aren't #269

KatieWoe opened this issue Oct 27, 2021 · 7 comments
Labels

Comments

@KatieWoe
Copy link
Contributor

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#717.
The about dialog no longer reads out items when clicked on. They were read out in the published version of JT. In addition, the Physics and Chemistry labels on the testbooks aren't read out when clicked on.

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Friction‬
URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html
Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@stemilymill
Copy link

The check for updates dialog also does not read "This simulation is up to date" like it should.

friction.check.for.updates.only.close.trim.mp4

@zepumph
Copy link
Member

zepumph commented Oct 27, 2021

I see that all items in the aboutDialog are readingblocks in JT (https://phet.colorado.edu/sims/html/john-travoltage/latest/john-travoltage_en.html), but not in Friction on master. @jessegreenberg can you recommend how to proceed? Is it a bug, or is there something I'm not opting into.

@zepumph
Copy link
Member

zepumph commented Oct 27, 2021

I can confirm that JT on master also doesn't have these reading blocks. Over to @jessegreenberg for some assistance.

@jessegreenberg
Copy link
Contributor

Sorry about this. In order to get john-travoltage out I added a quick sim-specific solution to get certain text readable without impacting master. We should have an easier time instrumenting these Dialogs now. I created joist issues to do this, phetsims/joist#763.

@jessegreenberg
Copy link
Contributor

phetsims/joist#763 was done and is ready for review, this should no longer be an issue for Friction.

@zepumph
Copy link
Member

zepumph commented Nov 10, 2021

Thanks! Removing blocking label, as things are working well in friction.

@Nancy-Salpepi
Copy link

Looks good on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants