Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when 2 buttons are pressed at same time on iPad #266

Closed
Nancy-Salpepi opened this issue Oct 15, 2021 · 11 comments
Closed

Issue when 2 buttons are pressed at same time on iPad #266

Nancy-Salpepi opened this issue Oct 15, 2021 · 11 comments

Comments

@Nancy-Salpepi
Copy link

Test device
iPad Air 2 (name: Leibniz)

Operating System
15.0.1

Browser
safari

Problem description
phetsims/qa#717

On the iPad:
When the reset button is pressed at the same time as one of the 'Read Me' buttons, the sim will reset. However, the 'Read Me' button will look like it is in play mode--a STOP symbol is present. If reset is pressed again, the button will not change back to a PLAY symbol.

Steps to reproduce

  1. Turn on voicing
  2. Toolbar option should be on
  3. Press the reset button and any of the 'Read Me' buttons at the same time.

Visuals

2.buttons.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1024x1224 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 15 uniform: 1024 Texture: size: 8192 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}
@jessegreenberg
Copy link
Contributor

These buttons switch back to the "play" icon from the voicingManager.endSpeakingEmitter so my first guess is that that emitter is not being emitted for some reason.

@emily-phet
Copy link

@jessegreenberg is planning to do some work to the utterance queue re priorities for when things are read out, when things are interrupted, etc. This seems related, or at least, likely in that ballpark area of Voicing work.

I don't think this should block further progress toward publication for Friction.

@emily-phet
Copy link

@jessegreenberg - I'm not sure if I should mark this as deferred, or if it should be listed in a different repo to be considered for some of the general Voicing work you'd like to do.

@emily-phet emily-phet assigned jessegreenberg and unassigned zepumph Oct 22, 2021
@emily-phet
Copy link

Another thought - @Nancy-Salpepi can you check if this same issue happens in other sims with voicing on iPad (e.g., JT and GFLB)?

I just want to check if this is Friction specific, or general.

@Nancy-Salpepi
Copy link
Author

@emily-phet I was easily able to reproduce this in JT (published) and GFLB (Master).

@jessegreenberg
Copy link
Contributor

We want to verify that the end event is not triggering. If that is the case it will likely be a browser bug and we will need to look into a workaround. I started phetsims/scenery#1315 to investigate.

@emily-phet
Copy link

This seems like a relatively minor usability issue to me. If @jessegreenberg finds this to be relatively straightforward to fix, or relatively straightforward to identify as a browser bug, then let's fix it in the case of it not being a browser bug. If it's a browser issue or a fix that's likely to delay publication, then I don't think this should be blocking for publication of Friction.

@zepumph
Copy link
Member

zepumph commented Nov 3, 2021

Today during voicing meeting we decided this won't block friction, @jessegreenberg will investigate for phetsims/scenery#1315.

@jessegreenberg
Copy link
Contributor

I suspect this has been fixed with phetsims/utterance-queue#66. I tried to get the original issue to happen on my iPad Air 2 and could not. @Nancy-Salpepi if you have a moment can you please test?

@Nancy-Salpepi
Copy link
Author

@jessegreenberg sometimes when both buttons are pressed at the same time, I hear the 'Reset All' sound and voicing either says "reset all" and then reads the Quick Info statements or reads the statements and then says "reset all".

I was not able to reproduce the original issue.

Videos:

friction2.mov
friction.mov

@zepumph
Copy link
Member

zepumph commented Aug 26, 2022

None of the above videos seemed like a bug to me. I think it is reasonable that you could hear one or both of the responses depending on how things end up in the queue. I don't think it is worth looking into this edge case any more. I'm going to close. Please reopen if you feel differently.

@zepumph zepumph closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants