Voicing reads line break in keyboard dialog

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
iOS 11.6

Browser
safari 15

Problem description
phetsims/qa#717

The line break element is read with Voicing in the 'Grab or Release Book' section of the Keyboard Shortcuts Dialog.

Steps to reproduce

1. Turn Voicing on
2. Open Keyboard shortcuts dialog
3. Tab to or click on 'Grab or Release Book' section

Visuals

textbreak.mov

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.19/phet/friction_all_phet.html Version: 1.6.0-dev.19 2021-10-08 22:59:15 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15 Language: en-US Window: 1440x675 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[zepumph]

There are quite a few spots where we are using html in our strings for a11y, since they were going into the PDOM. We need to split those out most likely, or come up with a way to remove the formatting tags.

[zepumph]

Looks like @jessegreenberg will be handling this on master and patching old versions over in phetsims/scenery#1309. @jessegreenberg I just thought you should be aware of this sim-issue as well.

[jessegreenberg]

I see, thanks. The plan in phetsims/scenery#1309 would not cover cases like this for Voicing. The fix there will simply be to replace <br> with <br/>, but the <br/> would also be ready by SpeechSynthesis. I think we will need another way to remove all formatting tags before speaking.

I started phetsims/scenery#1314 for this.

[zepumph]

Right, thanks! I'll take the lead over in phetsims/scenery#1314.

[zepumph]

Just waiting on review over in phetsims/scenery#1314.

[zepumph]

Alright, review is complete. @Nancy-Salpepi can you confirm this is fixed on master please?

[zepumph]

Feel free to close.

[Nancy-Salpepi]

This is fixed :)
Closing.