From 95ae2ead77285ffc1bc5cc02f3359b08c8bf0a15 Mon Sep 17 00:00:00 2001 From: denz1994 Date: Fri, 21 Dec 2018 12:55:07 -0500 Subject: [PATCH] Added REVIEW comments https://github.com/phetsims/fractions-common/issues/29 --- js/building/model/Animator.js | 1 + js/fractions-common-tests.js | 1 + js/fractionsCommon.js | 1 + 3 files changed, 3 insertions(+) diff --git a/js/building/model/Animator.js b/js/building/model/Animator.js index edfe59c..bd5fad7 100644 --- a/js/building/model/Animator.js +++ b/js/building/model/Animator.js @@ -21,6 +21,7 @@ define( require => { constructor( config ) { // REVIEW: Should "config" be named "options"? This may just be a matter of preference. + // REVIEW: (Review amendment) I see we are using the config pattern here, not too sure of the difference from options. config = _.extend( { // {Property.} diff --git a/js/fractions-common-tests.js b/js/fractions-common-tests.js index 2525b6a..d9ca3ea 100644 --- a/js/fractions-common-tests.js +++ b/js/fractions-common-tests.js @@ -1,5 +1,6 @@ // Copyright 2018, University of Colorado Boulder +// REVIEW: Author notation is different from other files. Was this intentional? /** * Unit tests. Please run once in phet brand. * diff --git a/js/fractionsCommon.js b/js/fractionsCommon.js index 6178de8..83f2960 100644 --- a/js/fractionsCommon.js +++ b/js/fractionsCommon.js @@ -8,6 +8,7 @@ define( require => { 'use strict'; + // REVIEW: 'const' instead of 'var' // modules var Namespace = require( 'PHET_CORE/Namespace' );